netdev - RE: Performance problem with bond interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d1712c10-930c-46e8-b1bb-7ce764b67479@default>
Date:	Tue, 22 Apr 2014 10:04:25 -0700 (PDT)
From:	Venkat Venkatsubra <venkat.x.venkatsubra@...cle.com>
To:	Eric Dumazet <eric.dumazet@...il.com>,
	Michał Mirosław <mirq-linux@...e.qmqm.pl>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	Rama Nichanamatlu <rama.nichanamatlu@...cle.com>,
	Sergey Linetskiy <sergey.linetskiy@...cle.com>,
	Vadim Makhervaks <vadim.makhervaks@...cle.com>,
	Guangyu Sun <guangyu.sun@...cle.com>
Subject: RE: Performance problem with bond interface

What is the purpose of initializing "features"
with NETIF_F_HW_CSUM in bond_setup() ?

[drivers/net/bonding/bond_main.c] bond-setup():
bond_dev->hw_features &= ~(NETIF_F_ALL_CSUM & ~NETIF_F_HW_CSUM);
bond_dev->features |= bond_dev->hw_features;

If netdev_increment_features() adds features in
incremental fashion then shouldn't bond let the
features such as NETIF_F_HW_CSUM be added when
netdev_increment_features() is called for each slave
in bond_compute_features() if the slave supports it ?

Thanks.

Venkat
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html