netdev - Re: [PATCH 1/1] iproute2: v3: Add support to configure SR-IOV VF minimum and maximum Tx rate through ip tool.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140422154051.26e584ce@nehalam.linuxnetplumber.net>
Date:	Tue, 22 Apr 2014 15:40:51 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Sucheta Chakraborty <sucheta.chakraborty@...gic.com>
Cc:	<netdev@...r.kernel.org>, <Dept-HSGLinuxNICDev@...gic.com>,
	<ben@...adent.org.uk>, <gregory.v.rose@...el.com>,
	<linux-net-drivers@...arflare.com>, <Ariel.Elior@...gic.com>,
	<amirv@...lanox.com>, <mkubecek@...e.cz>
Subject: Re: [PATCH 1/1] iproute2: v3: Add support to configure SR-IOV VF
 minimum and maximum Tx rate through ip tool.

On Mon, 14 Apr 2014 00:37:00 -0400
Sucheta Chakraborty <sucheta.chakraborty@...gic.com> wrote:

> o "min_tx_rate" option has been added for minimum Tx rate. Hence, for
>   consistent naming, "max_tx_rate" option has been introduced for maximum
>   Tx rate.
> 
> o Change in v2: "rate" can be used along with "max_tx_rate".
>   When both are specified, "max_tx_rate" should override.
> 
> o Change in v3:
>   * IFLA_VF_RATE: When IFLA_VF_RATE is used, and user has given only one of
>     min_tx_rate or max_tx_rate, reading of previous rate limits is done in
>     userspace instead of in kernel space before ndo_set_vf_rate.
> 
>   * IFLA_VF_TX_RATE: When IFLA_VF_TX_RATE is used, min_tx_rate is always read
>     in kernel space. This takes care of below scenarios:
>     (1) when old tool sends "rate" but kernel is new (expects min and max)
>     (2) when new tool sends only "rate" but kernel is old (expects only "rate")
> 
> Signed-off-by: Sucheta Chakraborty <sucheta.chakraborty@...gic.com>

I like the concept fine, but the general policy of ip route commands is
that the output format should match the input (except for statistics).

This (and ther earlier tx_rate patch are printing values in a different format
than the input

i.e don't print:
	max tx rate 110 (Mbps)
instead print:
	max_tx_rate 110Mbps


	

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html