netdev - Re: [RFC][PATCH] IP: Make ping sockets optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1398268542.7767.145.camel@deadeye.wl.decadent.org.uk>
Date:	Wed, 23 Apr 2014 16:55:42 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Florian Westphal <fw@...len.de>
Cc:	netdev <netdev@...r.kernel.org>,
	Vasiliy Kulikov <segoon@...nwall.com>
Subject: Re: [RFC][PATCH] IP: Make ping sockets optional

On Wed, 2014-04-23 at 17:30 +0200, Florian Westphal wrote:
> Ben Hutchings <ben@...adent.org.uk> wrote:
> > ICMP ping sockets currently require a new ping binary and are only
> > available after setting a sysctl.  The code adds about 10K to the
> > (uncompressed) size of the kernel.  Make this optional and disable
> > it by default.
> > 
> > This is compile-tested only; I'd just like to see whether people think
> > this is worth doing.
> 
> Either this feature needs to be ripped out now or it has to be kept.
> 
> I do not think the middle-ground you're proposing will work:
> 
> If userspace cannot safely assume facility is available, binaries
> need to be setuid to implement fallback, and when you go down that
> road you've gained nothing and might as well not support ping sockets
> at all.

Userspace can't assume it now because access is controlled by a sysctl.

I think it is for distributions to choose whether to enable this feature
in ping and the kernel.

Ben.

-- 
Ben Hutchings
Beware of programmers who carry screwdrivers. - Leonard Brandwein

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)