netdev - Question about TLP patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 23 Apr 2014 16:09:19 -0700
From:	Ji <lijimlee@...il.com>
To:	netdev@...r.kernel.org
Subject: Question about TLP patch

When reading the patch of Tail Loss Probe:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=6ba8a3b19e764b6a65e4030ab0999be50c291e6c
, I noticed this change:

@@ -2321,7 +2322,7 @@ static bool tcp_time_to_recover(struct sock *sk, int flag)
* interval if appropriate.
*/
if (tp->do_early_retrans && !tp->retrans_out && tp->sacked_out &&
- (tp->packets_out == (tp->sacked_out + 1) && tp->packets_out < 4) &&
+ (tp->packets_out >= (tp->sacked_out + 1) && tp->packets_out < 4) &&
!tcp_may_send_now(sk))
return !tcp_pause_early_retransmit(sk, flag);

I think the original code is because of RFC5827 Early Retransmit for TCP, 3.2
"... When conditions (3.a) and (3.b) hold and a TCP connection does

   support SACK or SCTP is in use, Early Retransmit MUST be used only

   when "oseg - 1" segments have been SACKed...."

With that change, it seems that the condition is relaxed. I wonder
why it is so. Could you cast some lights on it?

Thanks,
Ji Li
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html