netdev - RE: RFC: rtnetlink problems with Cisco enic and VFs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6CE81A2095B0024BBC77007BD04E553823E87A41@xmb-aln-x02.cisco.com>
Date:	Wed, 23 Apr 2014 02:33:06 +0000
From:	"Christian Benvenuti (benve)" <benve@...co.com>
To:	David Miller <davem@...emloft.net>,
	"dgibson@...hat.com" <dgibson@...hat.com>
CC:	"gregory.v.rose@...el.com" <gregory.v.rose@...el.com>,
	"ben@...adent.org.uk" <ben@...adent.org.uk>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Sujith Sankar (ssujith)" <ssujith@...co.com>,
	"govindarajulu90@...il.com" <govindarajulu90@...il.com>,
	"Neel Patel (neepatel)" <neepatel@...co.com>,
	"nistrive@...co.com" <nistrive@...co.com>
Subject: RE: RFC: rtnetlink problems with Cisco enic and VFs

> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-
> owner@...r.kernel.org] On Behalf Of David Miller
> Sent: Tuesday, April 22, 2014 6:17 PM
> To: dgibson@...hat.com
> Cc: gregory.v.rose@...el.com; ben@...adent.org.uk;
> netdev@...r.kernel.org; Christian Benvenuti (benve); Sujith Sankar
> (ssujith); govindarajulu90@...il.com; Neel Patel (neepatel);
> nistrive@...co.com
> Subject: Re: RFC: rtnetlink problems with Cisco enic and VFs
> 
> From: David Gibson <dgibson@...hat.com>
> Date: Wed, 23 Apr 2014 11:12:03 +1000
> 
> > And therein lies the problem.  I don't even know what the
> > IFLA_VF_PORTS info is for, but presumably something uses it.  If they
> > stop receiving it, they can be expected to break horribly.

In the case of Enic, libvirt uses IFLA_VF_PORTS in the context of the port profile
(see virtualport section and 802.1Qbh in the libvirt network xml documentation).

As Miller said, libvirt and iproute2 are the two known users (with libvirt being the main one)
but you never know what else may be using it.

> We did the same thing to VFINFO list.

I guess you refer to Bugzilla 889319.

> All the users I could find already set the mask unconditionally for all device
> dumps.
> 
> It's absolutely, positively, the only reasonable fix for this problem.

The fix based on IFLA_EXT_MASK seems reasonable to me
(IFLA_EXT_MASK is in use in libvirt >= 1.0.3 and iproute2 >=3.4.0 based on a quick check).

/Chris

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html