netdev - Re: basic question about LRO implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ3bTp4v9e4rXDh1-MzM13jsj6j56WJQa76GWwhXeOAx-fpg8A@mail.gmail.com>
Date:	Wed, 23 Apr 2014 09:15:57 +0530
From:	Rayagond Kokatanur <rayagond@...avyalabs.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: basic question about LRO implementation

Thank you.

On Tue, Apr 22, 2014 at 7:24 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Tue, 2014-04-22 at 13:28 +0530, Rayagond Kokatanur wrote:
>> Hi All,
>>
>> As part of LRO support, every Ethernet driver has to implement a call
>> back function ".get_skb_header" which does following,
>>
>> 1. Checks for TCP packet and return 0 for TCP packet and -1 for non-tcp packets
>> 2. Get tcp and ip header from given skb
>> 3. Initialize the flag to indicate IPv4 and  TCP packet.
>>
>> All these can be done by using skb - which is passed as input argument
>> to get_skb_header, there is nothing device specific we do in this api,
>> hence why can't this be implemented as generic api. By this way we can
>> avoid every driver implementing same api and hence duplicating the
>> same code.
>>
>> Please let me know if my understanding may be wrong.
>
> LRO is deprecated.
>
> Use GRO, even if hardware assisted like bnx2x driver ?
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html