netdev - Re: [PATCH net] net: filter: initialize A and X registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1398229980.29914.6.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 22 Apr 2014 22:13:00 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	ast@...mgrid.com, dborkman@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] net: filter: initialize A and X registers

On Tue, 2014-04-22 at 23:57 -0400, David Miller wrote:
> From: Alexei Starovoitov <ast@...mgrid.com>
> Date: Tue, 22 Apr 2014 20:18:57 -0700
> 
> > exisiting BPF verifier allows uninitialized access to registers,
> > 'ret A' is considered to be a valid filter.
> > So initialize A and X to zero to prevent leaking kernel memory
> > In the future BPF verifier will be rejecting such filters
> > 
> > Signed-off-by: Alexei Starovoitov <ast@...mgrid.com>
> 
> Has the code always been like this?
> 
> Did the eBPF changes introduce this problem either directly or
> indirectly?

Original code was fine AFAIK

Fixes: bd4cf0ed331a2 ("net: filter: rework/optimize internal BPF interpreter's instruction set")

David, is it possible for you to push net-next tree ?

Thank !


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html