netdev - Re: [PATCH net-next v4 3/3] net: ipv6: Use ip6_datagram_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53579FD8.2090309@enst-bretagne.fr>
Date:	Wed, 23 Apr 2014 13:11:20 +0200
From:	Florent Fourcot <florent.fourcot@...t-bretagne.fr>
To:	Lorenzo Colitti <lorenzo@...gle.com>, netdev@...r.kernel.org
CC:	yoshfuji@...ux-ipv6.org, hannes@...essinduktion.org,
	davem@...emloft.net, eric.dumazet@...il.com
Subject: Re: [PATCH net-next v4 3/3] net: ipv6: Use ip6_datagram_send_common
 in ping.

Le 22/04/2014 17:14, Lorenzo Colitti a écrit :> +
> +		if (sin6->sin6_family != AF_INET6)
> +			return -EAFNOSUPPORT;
> +

It has before returned -EINVAL, it changes the return to the user space.
You made it consistent with other protocols, but perhaps should you add
a notice in the commit changelog?

> -		if (sk->sk_bound_dev_if &&
> -		    sk->sk_bound_dev_if != u->sin6_scope_id) {
> -			return -EINVAL;
> -		}

What about this check now ?


Very good idea to simplify it, by the way.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html