netdev - Re: ax88796 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5357BA89.4070503@codethink.co.uk>
Date:	Wed, 23 Apr 2014 14:05:13 +0100
From:	Ben Dooks <ben.dooks@...ethink.co.uk>
To:	Ben Hutchings <ben@...adent.org.uk>,
	Alexander Varnin <fenixk19@...l.ru>
CC:	netdev@...r.kernel.org, Ben Dooks <ben-linux@...ff.org>
Subject: Re: ax88796 driver

On 22/04/14 02:59, Ben Hutchings wrote:
> On Thu, 2014-04-17 at 03:42 +0400, Alexander Varnin wrote:
>> Hello!
>>
>> I am currently working on kernel and dealing with ax88796 driver, that
>> has been written by Ben Dooks <ben@...tec.co.uk>. Since his address is
>> not available anymore (says "Ben doesn't work here any more"), I want
>> to ask help from somebody, who maybe somehow related to this driver.
>
> I'm cc'ing Ben, but I doubt he'll want to remember this driver.
>
> Ben.

Hi, I really do not remember this driver as we only used this device
on a couple of projects before changing to another supplier.

>> I want to ask on source code, because there is some non-obvious lines.
>>
>> Take a look on ax_initial_check function from ax88796.c please [1].
>>
>> Here is lines 127-129 of it:
>>
>> ei_outb (E8390_NODMA + E8390_PAGE1 + E8390_STOP, ioaddr + E8390_CMD);
>> regd = ei_inb (ioaddr + 0x0d);
>> ei_outb (0xff, ioaddr + 0x0d);
>>
>> This is supposed to be read and write to 0xD register on PAGE 1 of
>> AX88796. But that offset stands for "Multicast Address Register 5
>> ( MAR5 )" in AX88796 datasheet [2].
>>
>> What is the point of doing so? That looks very like a mistake. If it
>> is a mistake, I could make and send patch to fix it. But, please,
>> explain why is it done?
>>
>>
>> [1] http://lxr.free-electrons.com/source/drivers/net/ethernet/8390/ax88796.c#L116
>> [2] http://www.digchip.com/datasheets/parts/datasheet/562/AX88796-pdf.php

Hmm, is there an actual bug here or is this something that
we think is wrong? I could have a look but I do not have any
bootable test hardware available.

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html