netdev - Re: [net-next 07/13] igb: Cleanups to fix line length warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Apr 2014 12:40:03 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	carolyn.wyborny@...el.com, netdev@...r.kernel.org,
	gospo@...hat.com, sassmann@...hat.com
Subject: Re: [net-next 07/13] igb: Cleanups to fix line length warnings

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Thu, 24 Apr 2014 03:30:54 -0700

> From: Carolyn Wyborny <carolyn.wyborny@...el.com>
> 
> This patch fixes WARNING:LONG_LINE found with checkpatch check.
> 
> Signed-off-by: Carolyn Wyborny <carolyn.wyborny@...el.com>
> Tested-by: Aaron Brown <aaron.f.brown@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
>  drivers/net/ethernet/intel/igb/igb_ethtool.c | 13 ++++++++-----
>  drivers/net/ethernet/intel/igb/igb_main.c    |  8 +++++---
>  2 files changed, 13 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
> index 561df67..6aed00f 100644
> --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
> +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
> @@ -1129,8 +1129,10 @@ static struct igb_reg_test reg_test_82576[] = {
>  	{ E1000_RDBAH(4),  0x40, 12, PATTERN_TEST, 0xFFFFFFFF, 0xFFFFFFFF },
>  	{ E1000_RDLEN(4),  0x40, 12, PATTERN_TEST, 0x000FFFF0, 0x000FFFFF },
>  	/* Enable all RX queues before testing. */
> -	{ E1000_RXDCTL(0), 0x100, 4,  WRITE_NO_TEST, 0, E1000_RXDCTL_QUEUE_ENABLE },
> -	{ E1000_RXDCTL(4), 0x40, 12,  WRITE_NO_TEST, 0, E1000_RXDCTL_QUEUE_ENABLE },
> +	{ E1000_RXDCTL(0), 0x100, 4, WRITE_NO_TEST, 0,
> +						E1000_RXDCTL_QUEUE_ENABLE },

The second line should start at the same column as E1000_RXDCTL(0) on the first
line, rather than tabbed all the way to outer-space.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html