netdev - Re: [PATCH net-next v2 3/5] net: filter: get rid of sock_fprog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140424.160237.1682834218902091375.davem@davemloft.net>
Date:	Thu, 24 Apr 2014 16:02:37 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dborkman@...hat.com
Cc:	ast@...mgrid.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 3/5] net: filter: get rid of sock_fprog_kern

From: Daniel Borkmann <dborkman@...hat.com>
Date: Thu, 24 Apr 2014 08:45:25 +0200

> It is actually cleaner to just get rid of sock_fprog_kern structure.
> It's not really useful as we can just use sock_fprog structure as
> we do elsewhere in the kernel, this could throw some sparse false
> positives though, but getting rid of the structure duplication is
> probably the better way to go.
> 
> Signed-off-by: Daniel Borkmann <dborkman@...hat.com>
> Acked-by: Alexei Starovoitov <ast@...mgrid.com>

But this is the whole point of sock_fprog_kern.

It's so that we can always have the correct type for the pointers, and
we can show cleanly (without lots of ugly casts) to sparse that whether
we expect a pointer to be a user or a kernel one.

I really don't like this change, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html