netdev - Re: [Patch net] sched, cls: check if we could overwrite actions when changing a filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXkihRZN8Uf=KtaFexF1JP66Fztr+q3_tT4sMgOLMxGGQ@mail.gmail.com>
Date:	Thu, 24 Apr 2014 14:12:45 -0700
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Jamal Hadi Salim <jhs@...atatu.com>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Cong Wang <cwang@...pensource.com>
Subject: Re: [Patch net] sched, cls: check if we could overwrite actions when
 changing a filter

On Wed, Apr 23, 2014 at 4:30 AM, Jamal Hadi Salim <jhs@...atatu.com> wrote:
>
> I dont see what you are seeing. However, some quick tests will prove it.
> Example go from 1->3 actions and backwards 3->1 actions.
> I.e create a policy with (handwave) 3 actions and replace it with
> another that has only one action. Do this while you are sending a
> ping exercising this policy.
> I can see how yours with 1->0 and 0->1 will work.

See below (with this patch applied):

# tc filter show dev lo parent ffff:
filter protocol arp pref 49152 basic
filter protocol arp pref 49152 basic handle 0x1
        action order 1: mirred (Egress Mirror to device dummy1) pipe
        index 1 ref 1 bind 1

        action order 2: mirred (Egress Mirror to device dummy2) pipe
        index 2 ref 1 bind 1

        action order 3: mirred (Egress Mirror to device dummy3) pipe
        index 3 ref 1 bind 1

#  tc filter change dev lo parent ffff: protocol arp pref 49152 handle
1 basic action mirred egress mirror dev dummy1 index 1

# tc filter show dev lo parent ffff:
filter protocol arp pref 49152 basic
filter protocol arp pref 49152 basic handle 0x1
        action order 1: mirred (Egress Mirror to device dummy1) pipe
        index 1 ref 1 bind 1

 # tc action ls action mirred

        action order 0: mirred (Egress Mirror to device dummy1) pipe
        index 1 ref 1 bind 1
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html