netdev - Re: [PATCH] mrf24j40: seperate mrf24j40 h/w init and add checkings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <535882D0.8000600@cdac.in>
Date:	Thu, 24 Apr 2014 08:49:44 +0530
From:	Varka Bhadram <varkab@...c.in>
To:	Alan Ott <alan@...nal11.us>
CC:	Alexander Aring <alex.aring@...il.com>,
	Varka Bhadram <varkabhadram@...il.com>,
	linux-zigbee-devel@...ts.sourceforge.net,
	alex.bluesman.smirnov@...il.com, dbaryshkov@...il.com,
	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH] mrf24j40: seperate mrf24j40 h/w init and add checkings

Hi Alan,

My view is same as Alex view. If spi_sync() is not able to write and get 
the data we will get
an error number return.

The driver is allocating so many kernel resources even if you get the 
errno return also.
So this patch will return from driver probe() if spi_sync() returns err.

Thanks and Regards,
Varka Bhadram

On 04/23/2014 07:30 PM, Alexander Aring wrote:
> Hi Alan,
>
> On Wed, Apr 23, 2014 at 09:51:33AM -0400, Alan Ott wrote:
>> On 04/23/2014 09:11 AM, Varka Bhadram wrote:
>>> I followed the process that you mailed earlier, thnks for that.
>>>
>>> I am expecting the mail from Alan about the changes.
>> Hi Varka,
>>
>> Is there a specific problem you're seeing? Typically in the kernel we expect
>> the SPI controller to succeed for a couple reasons:
>> 1. It's part of the basic, core functionality of a system. Checking for
>> errors on SPI transfers is analogous to making sure RAM you wrote actually
>> got written.
>> 2. Most of the time an SPI failure is not something we can detect anyway.
>> (disconnect one of the lines and see what you get).
>> 3. The code to check for it just adds a lot of bloat without much measurable
>> benefit.
>>
>> I've read the above in the comments in other drivers, but I can't remember
>> exactly where right now. There are plenty of examples in the kernel of SPI
>> being done this way, as it seems to be accepted practice in the kernel.
>>
>> If there is a specific issue that you're seeing, then let's talk about it,
>> otherwise I'm going to NAK this change.
>>
> if somebody hasn't a right spi configuration the probe function should
> fail. Assumed that spi_sync will return a errno then.
>
> - Alex


-------------------------------------------------------------------------------------------------------------------------------

This e-mail is for the sole use of the intended recipient(s) and may
contain confidential and privileged information. If you are not the
intended recipient, please contact the sender by reply e-mail and destroy
all copies and the original message. Any unauthorized review, use,
disclosure, dissemination, forwarding, printing or copying of this email
is strictly prohibited and appropriate legal action will be taken.
-------------------------------------------------------------------------------------------------------------------------------

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html