netdev - Re: [PATCH] xfrm: Remove useless secid field from xfrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140424105505.GU32371@secunet.com>
Date:	Thu, 24 Apr 2014 12:55:05 +0200
From:	Steffen Klassert <steffen.klassert@...unet.com>
To:	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
CC:	<jmlatten@...ux.vnet.ibm.com>, <herbert@...dor.apana.org.au>,
	<davem@...emloft.net>, <netdev@...r.kernel.org>
Subject: Re: [PATCH] xfrm: Remove useless secid field from xfrm_audit.

On Tue, Apr 22, 2014 at 09:48:30PM +0900, Tetsuo Handa wrote:
> 
> Wow. I raced with your commit. I was making V2 patch because it seemed
> to me that
> 
>   struct xfrm_audit {
>   	u32     secid;
>   	kuid_t  loginuid;
>   	unsigned int sessionid;
>   };
> 
> can be packed as "bool" and replace "kuid_t auid, unsigned int ses, u32 secid"
> arguments with single bool argument.
> 
> I subtracted your commit from my V2 patch. Would you check below one?
> ----------
> >From 225dcb015abbad724cb4b6bda837e0132eb7b2dc Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
> Date: Tue, 22 Apr 2014 21:34:34 +0900
> Subject: [PATCH] xfrm: Remove useless xfrm_audit struct.
> 
> Commit f1370cc4 "xfrm: Remove useless secid field from xfrm_audit." changed
> "struct xfrm_audit" to have either
> { audit_get_loginuid(current) / audit_get_sessionid(current) } or
> { INVALID_UID / -1 } pair.
> 
> This means that we can represent "struct xfrm_audit" as "bool".
> This patch replaces "struct xfrm_audit" argument with "bool".
> 
> Signed-off-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>

Looks good, also applied.

Thanks a lot!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html