netdev - Re: [PATCH net-next v4 1/3] net: ipv6: Unduplicate {raw,udp}v6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140424150206.GF1960@order.stressinduktion.org>
Date:	Thu, 24 Apr 2014 17:02:06 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Lorenzo Colitti <lorenzo@...gle.com>, netdev@...r.kernel.org,
	yoshfuji@...ux-ipv6.org, davem@...emloft.net,
	eric.dumazet@...il.com
Subject: Re: [PATCH net-next v4 1/3] net: ipv6: Unduplicate {raw,udp}v6_sendmsg code

On Thu, Apr 24, 2014 at 05:00:19PM +0200, Hannes Frederic Sowa wrote:
> On Wed, Apr 23, 2014 at 03:37:56PM +0900, Lorenzo Colitti wrote:
> >  	if (msg->msg_flags&MSG_CONFIRM)
> >  		goto do_confirm;
> > @@ -1262,8 +1164,6 @@ back_from_confirm:
> >  	up->pending = AF_INET6;
> >  
> >  do_append_data:
> > -	if (dontfrag < 0)
> > -		dontfrag = np->dontfrag;
> 
> I am afraid we could jump to do_append_data without having dontfrag
> initialized. The jump happens before we call to ip6_datagram_send_common.
> 
> So the initialization of dontfrag to -1 needs to be added to the caller.

Also see e36d3ff91130002 (udp6: respect IPV6_DONTFRAG sockopt in case there
are pending frames) which was a bug we had some time ago.

Bye,

  Hannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html