netdev - Re: [Patch net] sched, cls: check if we could overwrite actions when changing a filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpV9g3PR0zPsM_4yHDrGKb+BAFk8=_SO8-x+R_gT9WzwUA@mail.gmail.com>
Date:	Fri, 25 Apr 2014 13:41:17 -0700
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Jamal Hadi Salim <jhs@...atatu.com>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Cong Wang <cwang@...pensource.com>
Subject: Re: [Patch net] sched, cls: check if we could overwrite actions when
 changing a filter

On Fri, Apr 25, 2014 at 8:48 AM, Jamal Hadi Salim <jhs@...atatu.com> wrote:
> On 04/24/14 17:12, Cong Wang wrote:
>>
>> On Wed, Apr 23, 2014 at 4:30 AM, Jamal Hadi Salim <jhs@...atatu.com>
>> wrote:
>>>
>>>
>>> I dont see what you are seeing. However, some quick tests will prove it.
>>> Example go from 1->3 actions and backwards 3->1 actions.
>>> I.e create a policy with (handwave) 3 actions and replace it with
>>> another that has only one action. Do this while you are sending a
>>> ping exercising this policy.
>>> I can see how yours with 1->0 and 0->1 will work.
>>
>>
>> See below (with this patch applied):
>>
>
> Ok, thanks Cong. Since you are using this in your system already,
> I am assuming it is tested with running traffic at the same time.

Yes I did.

>
> Please resubmit the patch with my signed off as well..
>

OK, and will rebase it on net-next since it is not an urgent issue.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html