netdev - Re: [PATCH net] bridge: Handle IFLA_ADDRESS correctly when creating bridge device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1398413925.3920.15.camel@ubuntu-vm-makita>
Date:	Fri, 25 Apr 2014 17:18:45 +0900
From:	Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
To:	Tom Gundersen <teg@...m.no>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Stephen Hemminger <stephen@...workplumber.org>,
	netdev <netdev@...r.kernel.org>,
	bridge <bridge@...ts.linux-foundation.org>,
	"C. R. Oldham" <cr@...tstack.com>
Subject: Re: [PATCH net] bridge: Handle IFLA_ADDRESS correctly when creating
 bridge device

On Thu, 2014-04-24 at 18:04 +0200, Tom Gundersen wrote:
> On Thu, Apr 24, 2014 at 2:16 PM, Toshiaki Makita
> <makita.toshiaki@....ntt.co.jp> wrote:
> > When bridge device is created with IFLA_ADDRESS, we are not calling
> > br_stp_change_bridge_id(), which leads to incorrect local fdb
> > management and bridge id calculation, and prevents us from receiving
> > frames on the bridge device.
> >
> > Reported-by: Tom Gundersen <teg@...m.no>
> 
> Thanks. That looks correct to me (not able to test at the moment
> though). Would this be appropriate for stable if it goes in?

This can apply 3.14 as is.
For 3.12 or earlier tree, this needs modification to insert the fdb
entry (or backport fdb fix patchset (684bd2e1)).
And for 3.2, another patch needs to be backported before this because
br_fdb_change_mac_address() doesn't exist.

Thanks,
Toshiaki Makita

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html