netdev - RE: [PATCH net-next 2/2] qlcnic: Use pci_enable_msix_exact() instead of pci_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <262CB373A6D1F14F9B81E82F74F77D5A46F9EEA2@avmb2.qlogic.org>
Date:	Fri, 25 Apr 2014 09:02:02 +0000
From:	Shahed Shaikh <shahed.shaikh@...gic.com>
To:	Alexander Gordeev <agordeev@...hat.com>
CC:	linux-kernel <linux-kernel@...r.kernel.org>,
	Dept-HSG Linux NIC Dev <Dept-HSGLinuxNICDev@...gic.com>,
	netdev <netdev@...r.kernel.org>,
	linux-pci <linux-pci@...r.kernel.org>
Subject: RE: [PATCH net-next 2/2] qlcnic: Use pci_enable_msix_exact()
 instead of pci_enable_msix()

> -----Original Message-----
> From: Alexander Gordeev [mailto:agordeev@...hat.com]
> Sent: Friday, April 25, 2014 2:31 PM
> To: Shahed Shaikh
> Cc: linux-kernel; Dept-HSG Linux NIC Dev; netdev; linux-pci
> Subject: Re: [PATCH net-next 2/2] qlcnic: Use pci_enable_msix_exact()
> instead of pci_enable_msix()
> 
> On Fri, Apr 25, 2014 at 08:48:14AM +0000, Shahed Shaikh wrote:
> > > diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> > > b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> > > index dbf7539..26f022b 100644
> > > --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> > > +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
> > > @@ -690,8 +690,8 @@ int qlcnic_setup_tss_rss_intr(struct
> > > qlcnic_adapter
> > > *adapter)
> > >  		adapter->msix_entries[vector].entry = vector;
> > >
> > >  restore:
> > > -	err = pci_enable_msix(pdev, adapter->msix_entries, num_msix);
> > > -	if (err > 0) {
> > > +	err = pci_enable_msix_exact(pdev, adapter->msix_entries,
> > > num_msix);
> > > +	if (err == -ENOSPC) {
> > >  		if (!adapter->drv_tss_rings && !adapter->drv_rss_rings)
> > >  			return -ENOSPC;
> >
> > I think, it would be good if we return "err" instead of "-ENOSPC" .
> >
> >                 if (!adapter->drv_tss_rings && !adapter->drv_rss_rings)
> > -                       return -ENOSPC;
> > +                       return err;
> 
> At this point "err" could only be -ENOSPC. I am not sure why returning "err" is
> better, but I'll repost if you insist.

Agree. But it will make code look cleaner.

Thanks,
Shahed
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html