netdev - Re: [PATCH] net phy: Check for aneg completion before setting state to PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140425.130845.1535177441530671772.davem@davemloft.net>
Date:	Fri, 25 Apr 2014 13:08:45 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	kumaran.4353@...il.com
Cc:	f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net phy: Check for aneg completion before setting
 state to PHY_RUNNING

From: Balakumaran Kannan <kumaran.4353@...il.com>
Date: Fri, 25 Apr 2014 11:23:03 +0530

> Here I have a doubt.
>  * Linux network initialization and phy_state_machine runs in separate threads.
>  * And driver doesn't bother about state of phydev.
> Is it correct?
> Doesn't driver need to confirm phydev is ready(PHY_RUNNING) before
> returning to kernel?

The one comment I will make about things here is that the phylib layer
really should not call netif_carrier_on() until the PHY really is
confirmed to be in a state where it will successfully pass traffic.

If it is doing so before auto-negotiation completes and succeeds,
that would be a bug.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html