netdev - Re: [PATCH v3 net] net: sctp: Don't transition to PF state when transport has exhausted 'Path.Max.Retrans'.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <535A9C93.9090106@gmail.com>
Date:	Fri, 25 Apr 2014 13:34:11 -0400
From:	Vlad Yasevich <vyasevich@...il.com>
To:	Karl Heiss <kheiss@...il.com>, netdev@...r.kernel.org
CC:	linux-sctp@...r.kernel.org, davem <davem@...emloft.net>,
	Neil Horman <nhorman@...driver.com>
Subject: Re: [PATCH v3 net] net: sctp: Don't transition to PF state when transport
 has exhausted 'Path.Max.Retrans'.

On 04/25/2014 01:21 PM, Karl Heiss wrote:
> On Fri, Apr 25, 2014 at 1:06 PM, Karl Heiss <kheiss@...il.com> wrote:
>> Don't transition to the PF state on every strike after 'Path.Max.Retrans'.
>> Per draft-ietf-tsvwg-sctp-failover-03 Section 5.1.6:
>>
>>    Additional (PMR - PFMR) consecutive timeouts on a PF destination
>>    confirm the path failure, upon which the destination transitions to the
>>    Inactive state.  As described in [RFC4960], the sender (i) SHOULD notify
>>    ULP about this state transition, and (ii) transmit heartbeats to the
>>    Inactive destination at a lower frequency as described in Section 8.3 of
>>    [RFC4960].
>>
>> This also prevents sending SCTP_ADDR_UNREACHABLE to the user as the state
>> bounces between SCTP_INACTIVE and SCTP_PF for each subsequent strike.
>>
>> Signed-off-by: Karl Heiss <kheiss@...il.com>
>> ---
>> Changes in v2:
>>   - Flesh out commit message
>>
>> Changes in v3:
>>   - Compare transport state instead of pathmaxrxt
>>
>>  net/sctp/sm_sideeffect.c |    5 +++--
>>  1 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
>> index 5d6883f..7805623 100644
>> --- a/net/sctp/sm_sideeffect.c
>> +++ b/net/sctp/sm_sideeffect.c
>> @@ -496,11 +496,12 @@ static void sctp_do_8_2_transport_strike(sctp_cmd_seq_t *commands,
>>
>>         /* If the transport error count is greater than the pf_retrans
>>          * threshold, and less than pathmaxrtx, and if the current state
>> -        * is not SCTP_UNCONFIRMED, then mark this transport as Partially
>> -        * Failed, see SCTP Quick Failover Draft, section 5.1
>> +        * is not SCTP_UNCONFIRMED or SCTP_INACTIVE, then mark this transport
>> +        * as Partially Failed, see SCTP Quick Failover Draft, section 5.1
>>          */
>>         if ((transport->state != SCTP_PF) &&
>>            (transport->state != SCTP_UNCONFIRMED) &&
>> +          (transport->state != SCTP_INACTIVE) &&
> 
> On second thought, would this not make more sense to be:
> 
>          if ((transport->state == SCTP_ACTIVE) &&
> 
> Since the only valid transition into PF is from ACTIVE?

Hmm..  we that UNKNOWN state, but it doesn't look like it survives
past the handshake...

So, yes, this would simplify things.

-vlad

> 
>>            (asoc->pf_retrans < transport->pathmaxrxt) &&
>>            (transport->error_count > asoc->pf_retrans)) {
>>
>> --
>> 1.7.1
>>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html