netdev - Re: [net] i40e: fix Timesync Tx interrupt handler code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140426.125614.583874864644445070.davem@davemloft.net>
Date:	Sat, 26 Apr 2014 12:56:14 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	jacob.e.keller@...el.com, netdev@...r.kernel.org, gospo@...hat.com,
	sassmann@...hat.com
Subject: Re: [net] i40e: fix Timesync Tx interrupt handler code

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Thu, 24 Apr 2014 18:05:03 -0700

> From: Jacob Keller <jacob.e.keller@...el.com>
> 
> This patch fixes the PTP Tx timestamp interrupt handler. The original
> code misinterpreted the interrupt handler design. We were clearing the
> ena_mask bit for the Timesync interrupts. This is done to indicate that
> the interrupt will be handled in a scheduled work item (instead of
> immediately) and that work item is responsible for re-enabling the
> interrupts. However, the Tx timestamp was being handled immediately and
> nothing was ever re-enabling it. This resulted in a single interrupt
> working for the life of the driver.
> 
> This patch fixes the issue by instead clearing the bit from icr0 which
> is used to indicate that the interrupt was immediately handled and can
> be re-enabled right away. This patch also clears up a related issue due
> to writing the PRTTSYN_STAT_0 register, which was unintentionally
> clearing the cause bits for Timesync interrupts.
> 
> Change-ID: I057bd70d53c302f60fab78246989cbdfa469d83b
> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> Acked-by: Anjali Singhai Jain <anjali.singhai@...el.com>
> Acked-by: Shannon Nelson <shannon.nelson@...el.com>
> Tested-by: Kavindya Deegala <kavindya.s.deegala@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html