lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 26 Apr 2014 02:40:20 +0000 From: KY Srinivasan <kys@...rosoft.com> To: KY Srinivasan <kys@...rosoft.com>, Eric Dumazet <eric.dumazet@...il.com>, Stephen Hemminger <stephen@...workplumber.org> CC: "olaf@...fle.de" <olaf@...fle.de>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "jasowang@...hat.com" <jasowang@...hat.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "stable@...nel.org" <stable@...nel.org>, "apw@...onical.com" <apw@...onical.com>, "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>, "davem@...emloft.net" <davem@...emloft.net> Subject: RE: [PATCH net-next 1/1] hyperv: Properly handle checksum offload > -----Original Message----- > From: driverdev-devel-bounces@...uxdriverproject.org [mailto:driverdev- > devel-bounces@...uxdriverproject.org] On Behalf Of KY Srinivasan > Sent: Friday, April 25, 2014 7:24 PM > To: Eric Dumazet; Stephen Hemminger > Cc: olaf@...fle.de; netdev@...r.kernel.org; jasowang@...hat.com; linux- > kernel@...r.kernel.org; stable@...nel.org; apw@...onical.com; > devel@...uxdriverproject.org; davem@...emloft.net > Subject: RE: [PATCH net-next 1/1] hyperv: Properly handle checksum offload > > > > > -----Original Message----- > > From: Eric Dumazet [mailto:eric.dumazet@...il.com] > > Sent: Friday, April 25, 2014 6:15 PM > > To: Stephen Hemminger > > Cc: KY Srinivasan; davem@...emloft.net; netdev@...r.kernel.org; linux- > > kernel@...r.kernel.org; devel@...uxdriverproject.org; olaf@...fle.de; > > apw@...onical.com; jasowang@...hat.com; stable@...nel.org > > Subject: Re: [PATCH net-next 1/1] hyperv: Properly handle checksum > > offload > > > > On Fri, 2014-04-25 at 17:43 -0700, Stephen Hemminger wrote: > > > On Fri, 25 Apr 2014 11:45:14 -0700 > > > "K. Y. Srinivasan" <kys@...rosoft.com> wrote: > > > > > > > @@ -474,6 +477,9 @@ static int netvsc_start_xmit(struct sk_buff > > > > *skb, > > struct net_device *net) > > > > csum_info = (struct ndis_tcp_ip_checksum_info *)((void *)ppi + > > > > ppi->ppi_offset); > > > > > > > > + ip_hdr(skb)->check = 0; > > > > + csum_info->transmit.ip_header_checksum = 1; > > > > + > > > > if (net_trans_info & (INFO_IPV4 << 16)) > > > > csum_info->transmit.is_ipv4 = 1; > > > > else > > > > > > Linux doesn't need or want IP checksum offload. > > > It will not have any performance gain. > > > > > > BTW, was this patch even tested with IPv6 packets ??? > > No; I only tested this on ipv4. Oops; this would not work on ipv6. I am going to resend this patch. K. Y > > K. Y > > > > _______________________________________________ > devel mailing list > devel@...uxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists