netdev - Re: [PATCH 2/2] ipv6: Set flow label to skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 27 Apr 2014 23:39:13 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	therbert@...gle.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] ipv6: Set flow label to skb_hash on transmit

From: Tom Herbert <therbert@...gle.com>
Date: Sat, 26 Apr 2014 16:00:30 -0700 (PDT)

> -	ip6_flow_hdr(ipv6h, INET_ECN_encapsulate(0, dsfield), fl6->flowlabel);
> +	ip6_flow_hdr(ipv6h, INET_ECN_encapsulate(0, dsfield,
> +		     ip6_make_flowlabel(net, skb, fl6->flowlabel)));

This doesn't compile on the planet on which I live.

net/ipv6/ip6_tunnel.c: In function ‘ip6_tnl_xmit2’:
net/ipv6/ip6_tunnel.c:1049:8: error: too many arguments to function ‘INET_ECN_encapsulate’
        ip6_make_flowlabel(net, skb, fl6->flowlabel)));
        ^
In file included from include/net/ip_tunnels.h:11:0,
                 from net/ipv6/ip6_tunnel.c:50:
include/net/inet_ecn.h:43:20: note: declared here
 static inline __u8 INET_ECN_encapsulate(__u8 outer, __u8 inner)
                    ^
net/ipv6/ip6_tunnel.c:1049:8: error: too few arguments to function ‘ip6_flow_hdr’
        ip6_make_flowlabel(net, skb, fl6->flowlabel)));
        ^
In file included from include/net/inetpeer.h:15:0,
                 from include/net/route.h:28,
                 from include/net/ip.h:31,
                 from net/ipv6/ip6_tunnel.c:49:
include/net/ipv6.h:684:20: note: declared here
 static inline void ip6_flow_hdr(struct ipv6hdr *hdr, unsigned int tclass,
                    ^
make[1]: *** [net/ipv6/ip6_tunnel.o] Error 1
make: *** [net/ipv6/ip6_tunnel.o] Error 2