[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20140428.144926.436860974988702953.davem@davemloft.net>
Date: Mon, 28 Apr 2014 14:49:26 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: erik.hugne@...csson.com
Cc: netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net,
jon.maloy@...csson.com, maloy@...jonn.com, ying.xue@...driver.com,
paul.gortmaker@...driver.com, richard.alpe@...csson.com
Subject: Re: [PATCH net-next] tipc: fix out of bounds indexing
From: <erik.hugne@...csson.com>
Date: Mon, 28 Apr 2014 08:20:09 +0200
> From: Erik Hugne <erik.hugne@...csson.com>
>
> Commit 78acb1f9b898e85fa2c1e28e700b54b66b288e8d ("tipc: add
> ioctl to fetch link names") introduced a buffer overflow bug where
> specially crafted ioctl requests could cause out-of-bounds indexing
> of the node->links array. This was caused by an incorrect check vs
> MAX_BEARERS, and the static code checker complaint is:
> net/tipc/node.c:459 tipc_node_get_linkname() error: buffer overflow 'node->links' 2 <= 2
>
> Signed-off-by: Erik Hugne <erik.hugne@...csson.com>
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists