netdev - Re: [PATCH net-next] ethtool: exit the loop when invalid index occurs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140428.132905.1371318427947470918.davem@davemloft.net>
Date:	Mon, 28 Apr 2014 13:29:05 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	sakiwit@...il.com
Cc:	netdev@...r.kernel.org, VenkatKumar.Duvvuru@...lex.Com
Subject: Re: [PATCH net-next] ethtool: exit the loop when invalid index
 occurs

From: Jean Sacren <sakiwit@...il.com>
Date: Sun, 27 Apr 2014 02:20:38 -0600

> The commit 3de0b592394d ("ethtool: Support for configurable RSS hash
> key") introduced a new function ethtool_copy_validate_indir() with
> full iteration of the loop to validate the ring indices, which could
> be an overkill. To minimize the impact, we ought to exit the loop as
> soon as the invalid index occurs for the very first time. The
> remaining loop simply doesn't serve any more purpose.
> 
> Signed-off-by: Jean Sacren <sakiwit@...il.com>
> Cc: Venkata Duvvuru <VenkatKumar.Duvvuru@...lex.Com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html