netdev - Re: [PATCH 2/2] ipv6: Set flow label to skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+mtBx-umd3vmNggurFiugQXr_gb+14HvHo=jdaPnpC4cL=tdA@mail.gmail.com>
Date:	Mon, 28 Apr 2014 12:29:01 -0700
From:	Tom Herbert <therbert@...gle.com>
To:	Florent Fourcot <florent.fourcot@...t-bretagne.fr>
Cc:	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH 2/2] ipv6: Set flow label to skb_hash on transmit

On Mon, Apr 28, 2014 at 11:12 AM, Florent Fourcot
<florent.fourcot@...t-bretagne.fr> wrote:
> Le 27/04/2014 01:00, Tom Herbert a écrit :
>>       net->ipv6.sysctl.flowlabel_consistency = 1;
>> +     net->ipv6.sysctl.auto_flowlabels = 1;
>
> I do not like setting this option to one by default. The idea of
> flowlabel_consistency above was to be sure that all labels given by the
> host are in the control of the flow label manager.
>
> By enabling auto_flowlabels, we can have conflict between the flow label
> manager policy, and a randomly generated label.
>
What would be the consequences of such a conflict? Per RFC6437
stateless and stateful flow labels are selected from the same space,
the probability of collision between them is assumed to be non-zero.
We obviously can't make any assumptions on RX.

Thanks,
Tom

> And I do not have a strong opinion on it, but perhaps should
> auto_flowlabels depends of a disabled flowlabel_consistency, to have a
> coherent behaviour for users.
>
> Regards,
>
> Florent.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html