netdev - Re: problem forwarding IP fragments with DF bit set (caused by ipv4: fix path MTU discovery with connection tracking)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140429143324.GB12781@macbook.localnet>
Date:	Tue, 29 Apr 2014 15:33:27 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	Maxime Bizon <mbizon@...ebox.fr>
Cc:	Eric Dumazet <edumazet@...gle.com>, davem@...emloft.net,
	netdev <netdev@...r.kernel.org>
Subject: Re: problem forwarding IP fragments with DF bit set (caused by ipv4:
 fix path MTU discovery with connection tracking)

On Mon, Apr 28, 2014 at 06:37:36PM +0200, Maxime Bizon wrote:
> 
> Hello Patrick & Eric,
> 
> After upgrading a router with a kernel that has patch 5f2d04f1f9 (ipv4:
> fix path MTU discovery with connection tracking), some packets are not
> forwarded anymore.
> 
> (note: kernel is 3.11.10, and conntrack is enabled)
> 
> Offending packets are IP fragments with DF bit set, MTU is the same on
> both interfaces involved in forwarding. All received fragments are
> (obviously) below MTU. The resulting packet after re-assembly is however
> above MTU.
> 
> conntrack causes the packets to be re-assembled, but since the resulting
> skb now has IP_DF set, it fails the (DF + MTU) test in ip_forward.c and
> causes ICMP frag_needed to be sent.

That is the correct behaviour.

> Without the patch, the packet was (re-)fragmented in the output path
> (but as the patch says, breaking PMTUD because original fragment size is
> not considered).

Yes. The sending host should receive the ICMP frag needed and adjust it's
size accordingly.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html