netdev - Re: [net-next] vxlan: Advertise SCTP checksum offloads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+mtBx9eC5rVuD3GFSeCxvCkm_0W=_VOi8VJV8CofdpHyCpdGA@mail.gmail.com>
Date:	Tue, 29 Apr 2014 08:28:09 -0700
From:	Tom Herbert <therbert@...gle.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	David Miller <davem@...emloft.net>,
	Greg Rose <gregory.v.rose@...el.com>,
	Linux Netdev List <netdev@...r.kernel.org>, gospo@...hat.com,
	sassmann@...hat.com
Subject: Re: [net-next] vxlan: Advertise SCTP checksum offloads

Hi Jeff,

Since SCTP is using a variant of CRC32 in a fairly generic manner,
would it be possible to provide a general API to offload it like in
NETIF_F_HW_CSUM? A strong CRC offloaded might be useful for other
protocols.

Thanks,
Tom


On Mon, Apr 28, 2014 at 12:52 PM, Jeff Kirsher
<jeffrey.t.kirsher@...el.com> wrote:
> From: Greg Rose <gregory.v.rose@...el.com>
>
> Some HW can offload encapsulated SCTP checksums.  Advertise the capability
> for such cases.
>
> Signed-off-by: Greg Rose <gregory.v.rose@...el.com>
> Acked-by: Joseph Gasparakis <joseph.gasparakis@...el.com>
> Acked-by: Shannon Nelson <shannon.nelson@...el.com>
> Tested-by: Jeff Pieper <jeffrey.e.pieper@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
>  drivers/net/vxlan.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index 1dfee9a..988208f 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -2293,6 +2293,7 @@ static void vxlan_setup(struct net_device *dev)
>         dev->features   |= NETIF_F_SG | NETIF_F_HW_CSUM;
>         dev->features   |= NETIF_F_RXCSUM;
>         dev->features   |= NETIF_F_GSO_SOFTWARE;
> +       dev->features   |= NETIF_F_SCTP_CSUM;
>
>         dev->vlan_features = dev->features;
>         dev->features |= NETIF_F_HW_VLAN_CTAG_TX | NETIF_F_HW_VLAN_STAG_TX;
> --
> 1.9.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html