netdev - Re: [net-next] vxlan: Advertise SCTP checksum offloads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <535FE8D5.90600@gmail.com>
Date:	Tue, 29 Apr 2014 14:00:53 -0400
From:	Vlad Yasevich <vyasevich@...il.com>
To:	Joseph Gasparakis <jgaspara@...el.com>
CC:	"Rose, Gregory V" <gregory.v.rose@...el.com>,
	Ben Hutchings <ben@...adent.org.uk>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"Gasparakis, Joseph" <joseph.gasparakis@...el.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>
Subject: Re: [net-next] vxlan: Advertise SCTP checksum offloads

On 04/29/2014 01:34 PM, Joseph Gasparakis wrote:
> 
> 
> On Tue, 29 Apr 2014, Vlad Yasevich wrote:
> 
>> On 04/29/2014 12:10 PM, Rose, Gregory V wrote:
>>>
>>>> -----Original Message-----
>>>> From: Ben Hutchings [mailto:ben@...adent.org.uk]
>>>> Sent: Tuesday, April 29, 2014 5:39 AM
>>>> To: Kirsher, Jeffrey T
>>>> Cc: davem@...emloft.net; Rose, Gregory V; netdev@...r.kernel.org;
>>>> gospo@...hat.com; sassmann@...hat.com
>>>> Subject: Re: [net-next] vxlan: Advertise SCTP checksum offloads
>>>>
>>>> On Mon, 2014-04-28 at 12:52 -0700, Jeff Kirsher wrote:
>>>>> From: Greg Rose <gregory.v.rose@...el.com>
>>>>>
>>>>> Some HW can offload encapsulated SCTP checksums.  Advertise the
>>>>> capability for such cases.
>>>>
>>>> Don't we need a software fallback on the output path before doing this?
>>>
>>> I believe that the vxlan driver will compare offload features with the lower device hw_enc_feature flags and if the HW doesn't have the offload then it won't be advertised to the sctp driver.  In that case the sctp driver will do its own checksumming.  At least that is the behavior I saw.
>>>
>>
>> I've been looking at this and can't see vxlan doing any feature
>> comparisons/disabling...
>>
>> At the time SCTP tries to do checksum, it will see hw offload
>> support and set checksum as partial.  That will be propagated
>> all the way to vxlan which will set encapsulation and pass it on.
>> At next dev_hard_start_xmit(), we'll look at hw_enc_features,
>> but it won't matter since SCTP packets are never GSO.
>>
>> So, we'll use the non-gso code path and still send with partial
>> checksum set.  Now, if the driver supports encapsulated SCTP,
>> then it will work.  If it doesn't, the udp checksum will be computed,
>> but not the sctp one.
>>
>> -vlad
> 
> That is exactly the way it works, dev_hard_start_xmit() is where 
> the (inner) unchecksummed packets will get checksummed if the Tx'ing 
> interface does not support inner SCTP checksumming.

No, it will not.  dev_hard_start_xmit() calls skb_checksum_help()
which only knows how to calculate TCP/UDP checksums.  It doesn't know
how to compute CRC32c for SCTP protocol.

-vlad

> 
> In effect by "falsely" advertising vxlan being capable to "offload" a 
> protocol, we just postpone the software csum calculation until the last 
> minute, which is dev_hard_start_xmit().
> 
> Joseph
> 
>>
>>> I'm adding Joseph Gasparakis.  He might have a better answer.
>>>
>>> - Greg
>>>
>>>>
>>>> Ben.
>>>>
>>>>> Signed-off-by: Greg Rose <gregory.v.rose@...el.com>
>>>>> Acked-by: Joseph Gasparakis <joseph.gasparakis@...el.com>
>>>>> Acked-by: Shannon Nelson <shannon.nelson@...el.com>
>>>>> Tested-by: Jeff Pieper <jeffrey.e.pieper@...el.com>
>>>>> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
>>>>> ---
>>>>>  drivers/net/vxlan.c | 1 +
>>>>>  1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index
>>>>> 1dfee9a..988208f 100644
>>>>> --- a/drivers/net/vxlan.c
>>>>> +++ b/drivers/net/vxlan.c
>>>>> @@ -2293,6 +2293,7 @@ static void vxlan_setup(struct net_device *dev)
>>>>>  	dev->features	|= NETIF_F_SG | NETIF_F_HW_CSUM;
>>>>>  	dev->features   |= NETIF_F_RXCSUM;
>>>>>  	dev->features   |= NETIF_F_GSO_SOFTWARE;
>>>>> +	dev->features   |= NETIF_F_SCTP_CSUM;
>>>>>
>>>>>  	dev->vlan_features = dev->features;
>>>>>  	dev->features |= NETIF_F_HW_VLAN_CTAG_TX | NETIF_F_HW_VLAN_STAG_TX;
>>>>
>>>> --
>>>> Ben Hutchings
>>>> Q.  Which is the greater problem in the world today, ignorance or apathy?
>>>> A.  I don't know and I couldn't care less.
>>> N???????????????r??????y?????????b???X??????ǧv???^???)޺{.n???+?????????z???^???)?????????w*.jg?????????.???????????????ݢj/?????????z???ޖ??????2???ޙ?????????&???)ߡ???a????????????.???G?????????h???.???j:+v?????????w???٥
>>>
>>
>>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html