netdev - Re: [PATCH net] gianfar: Avoid unnecessary reg accesses in adjust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140430.161651.1135923239405605.davem@davemloft.net>
Date:	Wed, 30 Apr 2014 16:16:51 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	claudiu.manoil@...escale.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] gianfar: Avoid unnecessary reg accesses in
 adjust_link()

From: Claudiu Manoil <claudiu.manoil@...escale.com>
Date: Wed, 30 Apr 2014 14:27:21 +0300

> For phy devices that don't issue interrupts upon link
> state changes, phylib polls the link state resulting in
> repeated calls to adjust_link(), even if the link state
> didn't change.  As a result, some mac registers are
> repeatedly read and written with the same values, which
> is not ok.
> 
> To fix this, adjust_link() has been refactored to check
> first whether the link state has changed and to take action
> only if needed, updating mac registers and local state
> variables.  The 'new_state' local flag, set if one of the
> link params changed (link, speed or duplex), has been
> rendered useless and removed by this refactoring.
> 
> Signed-off-by: Claudiu Manoil <claudiu.manoil@...escale.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html