lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 Apr 2014 17:23:39 -0400 (EDT) From: David Miller <davem@...emloft.net> To: therbert@...gle.com Cc: netdev@...r.kernel.org, ben@...adent.org.uk Subject: Re: [PATCH 5/8 v3] net: Generalize checksum_init functions From: Tom Herbert <therbert@...gle.com> Date: Tue, 29 Apr 2014 09:18:47 -0700 (PDT) > + if (complete || skb->len <= 76) > + return __skb_checksum_complete(skb); Undocumented constant '76', it has no meaning to me as a reviewer. > + if (!__skb_checksum_validate_unnecessary(skb, zero_okay, check))\ > + __ret = __skb_checksum_validate_complete(skb, \ > + complete, compute_pseudo(skb, proto)); \ Please avoid double negatives. This would read more clearly if it was something like: if (__skb_checksum_validate_needed(skb, zero_okay, check)) __skb_checksum_validate_complete(...); -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists