lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 Apr 2014 15:25:31 -0700 From: John Fastabend <john.fastabend@...il.com> To: Eric Dumazet <eric.dumazet@...il.com> CC: xiyou.wangcong@...il.com, jhs@...atatu.com, netdev@...r.kernel.org, davem@...emloft.net Subject: Re: [RFC PATCH 01/15] net: qdisc: use rcu prefix and silence sparse warnings On 04/30/2014 10:00 AM, Eric Dumazet wrote: > On Wed, 2014-04-30 at 09:35 -0700, John Fastabend wrote: > >> static inline struct Qdisc *qdisc_root(const struct Qdisc *qdisc) >> { >> - return qdisc->dev_queue->qdisc; >> + struct Qdisc *q = rcu_dereference(qdisc->dev_queue->qdisc); >> + >> + return q; >> } >> > > Hmm... I am pretty sure this can be called without rcu_read_lock() > > rcu_dereference_rtnl() would be more appropriate here I think. > > It looks like it except for qdisc_watchdog() which needs an rcu_read_lock() if I'm not mistaken/ static enum hrtimer_restart qdisc_watchdog(struct hrtimer *timer) { struct qdisc_watchdog *wd = container_of(timer, struct qdisc_watchdog, timer); rcu_read_lock(); qdisc_unthrottled(wd->qdisc); __netif_schedule(qdisc_root(wd->qdisc)); rcu_read_unlock(); return HRTIMER_NORESTART; } -- John Fastabend Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists