netdev - Re: [RFC PATCH 01/15] net: qdisc: use rcu prefix and silence sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1398900557.29914.187.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 30 Apr 2014 16:29:17 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	John Fastabend <john.fastabend@...il.com>
Cc:	xiyou.wangcong@...il.com, jhs@...atatu.com, netdev@...r.kernel.org,
	davem@...emloft.net
Subject: Re: [RFC PATCH 01/15] net: qdisc: use rcu prefix and silence sparse
 warnings

On Wed, 2014-04-30 at 15:25 -0700, John Fastabend wrote:

> It looks like it except for qdisc_watchdog() which needs an
> rcu_read_lock() if I'm not mistaken/
> 
> static enum hrtimer_restart qdisc_watchdog(struct hrtimer *timer)
> {
> 	struct qdisc_watchdog *wd = container_of(timer, struct 		
> 						 qdisc_watchdog,
> 						 timer);
> 
> 	rcu_read_lock();
> 	qdisc_unthrottled(wd->qdisc);
> 	__netif_schedule(qdisc_root(wd->qdisc));
> 	rcu_read_unlock();
> 
> 	return HRTIMER_NORESTART;
> }
> 

Normally, HRTIMER handlers are run under softirq.

Anyway you could simply use following on your builds

CONFIG_PROVE_RCU=y



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html