lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 Apr 2014 13:21:01 -0300 From: Ezequiel Garcia <ezequiel.garcia@...e-electrons.com> To: Sebastian Hesselbarth <sebastian.hesselbarth@...il.com> Cc: netdev@...r.kernel.org, Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>, Lior Amsalem <alior@...vell.com>, Tawfik Bayouk <tawfik@...vell.com>, Gregory Clement <gregory.clement@...e-electrons.com>, "David S. Miller" <davem@...emloft.net>, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH for v3.15] net: mvmdio: Check for a valid interrupt instead of an error On Apr 30, Sebastian Hesselbarth wrote: > > > >Yes, I agree. Did another patch for that, but haven't send it yet. > >AFAICS, mvebu platforms will never hit the deferred case as the irqchip > >is the first driver registered (as per drivers/Makefile). > > > >Not that we should count on that :) > > It doesn't hit it _now_ because of the above. I read about proper > platform_device for early devices here and there over and over > again, so I guess some day it may become an issue. > > As we know about the potential -EPROBE_DEFER now, I suggest to > deal with it now, too. > > Can you resend this as v2 with the other patch you mentioned > squashed in? > Oh! I've just remembered why I didn't send the EPROBE_DEFER patch in the first place. The mvneta driver connects to the phy at open()-time, in a function called "mvneta_mdio_probe()". This name confused me to think the mdio was really probed at open()-time. I guess it was very late at night when I came to such conclusion :) -- Ezequiel GarcĂa, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists