lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 30 Apr 2014 10:00:28 -0700
From:	Eric Dumazet <>
To:	John Fastabend <>
Subject: Re: [RFC PATCH 01/15] net: qdisc: use rcu prefix and silence sparse

On Wed, 2014-04-30 at 09:35 -0700, John Fastabend wrote:

>  static inline struct Qdisc *qdisc_root(const struct Qdisc *qdisc)
>  {
> -	return qdisc->dev_queue->qdisc;
> +	struct Qdisc *q = rcu_dereference(qdisc->dev_queue->qdisc);
> +
> +	return q;
>  }

Hmm... I am pretty sure this can be called without rcu_read_lock()

rcu_dereference_rtnl() would be more appropriate here I think.

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists