netdev - Re: [net PATCH v2] net: sched: lock imbalance in hhf qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 01 May 2014 10:12:01 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	John Fastabend <john.fastabend@...il.com>
Cc:	netdev@...r.kernel.org, edumazet@...gle.com, vtlam@...gle.com
Subject: Re: [net PATCH v2] net: sched: lock imbalance in hhf qdisc

On Thu, 2014-05-01 at 09:23 -0700, John Fastabend wrote:
> hhf_change() takes the sch_tree_lock and releases it but misses the
> error cases. Fix the missed case here.
> 
> To reproduce try a command like this,
> 
> # tc qdisc change dev p3p2 root hhf quantum 40960 non_hh_weight 300000
> 
> Signed-off-by: John Fastabend <john.r.fastabend@...el.com>
> ---
>  net/sched/sch_hhf.c |   11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)

Signed-off-by: Eric Dumazet <edumazet@...gle.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html