netdev - Re: [PATCH] net: filter: add insn for loading internal transport header offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+ZOOTPm+--PMjvezym-fxY5cD2Q9EDUMgrAm1JohRVqU0z3pA@mail.gmail.com>
Date:	Thu, 1 May 2014 11:44:39 -0700
From:	Chema Gonzalez <chema@...gle.com>
To:	Daniel Borkmann <dborkman@...hat.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Alexei Starovoitov <ast@...mgrid.com>,
	Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: filter: add insn for loading internal transport
 header offset

On Thu, May 1, 2014 at 3:55 AM, Daniel Borkmann <dborkman@...hat.com> wrote:
>> [ Chema, please also keep me in cc if possible. ]
Done.

>> Looks good to me. For casting pointers as Dave noted recently, please
>> use 'unsigned long'. This needs to be fixed in other places as well.
Done.

> Ohh, and please in future include net or net-next into your subject line.
Done.

On Wed, Apr 30, 2014 at 3:21 PM, Alexei Starovoitov <ast@...mgrid.com> wrote:
>> +static u64 __skb_get_tra_offset(u64 ctx, u64 A, u64 X, u64 r4, u64 r5)
>> +{
>> +       struct flow_keys keys;
>> +       struct sk_buff *skb = (struct sk_buff *)(long) ctx;
>
> I think kernel style recommends to swap above two lines,
> but that's a nit.
Done.

-Chema
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html