lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 01 May 2014 11:50:13 -0700 From: Eric Dumazet <eric.dumazet@...il.com> To: Daniel Borkmann <dborkman@...hat.com> Cc: davem@...emloft.net, ast@...mgrid.com, netdev@...r.kernel.org Subject: Re: [PATCH net-next v3 1/3] net: filter: simplify label names from jump-table On Thu, 2014-05-01 at 19:39 +0200, Daniel Borkmann wrote: > Well, if you review the code itself in filter.c it makes it hard > to read and review, with this patch, you'll immediately get the > label name and what it actually does, so I think it's quite convenient > and way more readable by itself. For grepping, you can always add > subdirectories you're searching for, besides that I don't think > that everything in the kernel needs to have unique names only so > that one can grep for it among the whole tree. Considering that Alexei claimed : +Internal BPF is a general purpose RISC instruction set. Not every register and +every instruction are used during translation from original BPF to new format. +For example, socket filters are not using 'exclusive add' instruction, but +tracing filters may do to maintain counters of events, for example. Register R9 +is not used by socket filters either, but more complex filters may be running +out of registers and would have to resort to spill/fill to stack. I tried to verify this claim and I could not. After your patch, it will be really this : "We, Daniel and Alexei, hereby certify that this code is 100% safe. If you Eric, or anyone else, want to check, you'll have to grep in appropriate places, and use your brain as we did." I find very worrying all this stuff. This looks like you guys make everything possible to make it absolutely unmaintainable. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists