netdev - Re: [PATCH net 1/4] net/mlx4_core: Adjust port number in qp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 2 May 2014 13:43:34 +0300
From:	Or Gerlitz <or.gerlitz@...il.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	Or Gerlitz <ogerlitz@...lanox.com>,
	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Roland Dreier <roland@...nel.org>,
	Jack Morgenstein <jackm@....mellanox.co.il>,
	Matan Barak <matanb@...lanox.com>,
	Amir Vadai <amirv@...lanox.com>,
	Jack Morgenstein <jackm@...lanox.com>
Subject: Re: [PATCH net 1/4] net/mlx4_core: Adjust port number in qp_attach
 wrapper when detaching

On Thu, May 1, 2014 at 10:54 PM, Sergei Shtylyov
<sergei.shtylyov@...entembedded.com> wrote:
> On 05/01/2014 04:51 PM, Or Gerlitz wrote:

>> +static int mlx4_adjust_port(struct mlx4_dev *dev, int slave,
>> +                           u8 *gid, enum mlx4_protocol prot)
>> +{
>> +       int real_port;
>> +
>> +       if (prot != MLX4_PROT_ETH)
>> +               return 0;
>> +
>> +       if (dev->caps.steering_mode == MLX4_STEERING_MODE_B0 ||
>> +           (dev->caps.steering_mode == MLX4_STEERING_MODE_DEVICE_MANAGED)) {
>
>
>    It looks a bit strange when you enclose in parens the second == but not the first. In fact, they're not at all necessary.

Well... so we'll fix it and resubmit
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html