netdev - Re: [PATCH] mlx4: Use GFP_NOFS calls during the ipoib TX path when creating the QP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 2 May 2014 15:03:37 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Or Gerlitz <or.gerlitz@...il.com>
cc:	Or Gerlitz <ogerlitz@...lanox.com>,
	Roland Dreier <roland@...nel.org>,
	Sagi Grimberg <sagig@...lanox.com>,
	Amir Vadai <amirv@...lanox.com>,
	Eli Cohen <eli@....mellanox.co.il>,
	Eugenia Emantayev <eugenia@...lanox.com>,
	"David S. Miller" <davem@...emloft.net>,
	Mel Gorman <mgorman@...e.de>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Saeed Mahameed <saeedm@...lanox.com>,
	Shlomo Pongratz <shlomop@...lanox.com>
Subject: Re: [PATCH] mlx4: Use GFP_NOFS calls during the ipoib TX path when
 creating the QP

On Thu, 24 Apr 2014, Or Gerlitz wrote:

> I sent you private note on Mar 19th saying "are you on track with this
> for 3.15? the merge window is coming soon and you have 99% of what you
> need -- lets get there" which seems to be the piece that fell between
> the cracks.

I probably failed to see the implication that you/Mellanox is expecting me 
to deliver the final patch, sorry for that.

> > probably because it wasn't clearly stated *who* will be preparing 
> > patch(es) that'd be implementing the ideas above. My understanding was 
> > that it'd be Mellanox, given that they basically own the driver,
> 
> to be precise partially own the mlx4 HW driver (Roland is the
> mlx4_core/ib author and maintainer, we are asking for few years to get
> co-maintainer hat there, no success so far)

I am of course completely unfamiliar with internal affairs as this, so 
it's not really appropriate for me to comment, but if hardware vendor is 
not able to obtain maintainership of the driver for its own HW, that seems 
to signal some serious issues.

> , the problem you have described can happen with any HW driver, but as 
> stated earlier, the suggested plan will fix ipoib and mlx4 and following 
> that more hw drivers can be enhanced to support that too.
> 
> >
> > have the best testing coverage compared to very very limited
> > testing coverage I can do, and will be pushing it upstream anyway.
> >
> > I believe all the above can be easily created on top of the original patch I sent.
> 
> Indeed, so will take a look next week and let you know if it works for me

Excellent, thanks a lot, looking forward to any updates on this.

Thanks again,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html