netdev - Re: [PATCH] net: via-rhine: Drop revision property, use quirks instead

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140502.155635.1691085402453175737.davem@davemloft.net>
Date:	Fri, 02 May 2014 15:56:35 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	alchark@...il.com
Cc:	rl@...lgate.ch, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, David.Laight@...LAB.COM, mq@...e.cz
Subject: Re: [PATCH] net: via-rhine: Drop revision property, use quirks
 instead

From: Alexey Charkov <alchark@...il.com>
Date: Wed, 30 Apr 2014 22:21:09 +0400

> This adds two new flags to quirks and thus removes the need to carry
> revision in rhine_private. As a result, the init logic is simplified
> a bit.
> 
> This also fixes a compiler warning in OF code on 64bit due to pointer
> casting:
> 
>         drivers/net/ethernet/via/via-rhine.c: In function ‘rhine_init_one_platform’:
>         drivers/net/ethernet/via/via-rhine.c:1132:13: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>           revision = (u32)match->data;
>                      ^
> 
> That code was added in commit 2d283862dc62daead9db0dc89cd0d0351e91f765
> ("net: via-rhine: add OF bus binding").
> 
> Tested in platform configuration on a VIA WM8950 APC Rock board.
> 
> Reported-by: Jan Moskyto Matejka <mq@...e.cz>
> Signed-off-by: Alexey Charkov <alchark@...il.com>

This looks a lot better, applied, thanks.