netdev - Re: [PATCH net-next v2] net: filter: add insn for loading internal transport header offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140502.225252.1865694187680020950.davem@davemloft.net>
Date:	Fri, 02 May 2014 22:52:52 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	chema@...gle.com
Cc:	edumazet@...gle.com, dborkman@...hat.com, ast@...mgrid.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: filter: add insn for loading internal
 transport header offset

From: Chema Gonzalez <chema@...gle.com>
Date: Fri, 2 May 2014 17:53:01 -0700

> On Fri, May 2, 2014 at 2:49 PM, David Miller <davem@...emloft.net> wrote:
>> We can probably add an extension to AF_PACKET which provides the flow
>> key at the end of the tpacket3_hdr if a certain socket option is set.
>>
>> That would provide the transport header as well as a side effect, and
>> be much more powerful and efficient than this particular BPF
>> instruction.
> Once you get the L3 proto and noff/toff, you get everything. The
> rationale of adding toff/noff is that it's very similar to poff, which
> we already have.

But you're implementation is calling a function to do all of that work
already, just to get only the transport header and then throwing away
all of the other useful bits that function is calculating, so you'll
end up doing it twice which is wasted work.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html