| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140504214116.GI1156@newterm.pl> Date: Sun, 4 May 2014 23:41:17 +0200 From: Darek Marcinkiewicz <reksio@...term.pl> To: Francois Romieu <romieu@...zoreil.com> Cc: davem@...emloft.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v5 1/1] Driver for Beckhoff CX5020 EtherCAT master module. On Sun, May 04, 2014 at 11:19:28PM +0200, Francois Romieu wrote: > Darek Marcinkiewicz <reksio@...term.pl> : > > On Sun, May 04, 2014 at 08:43:51PM +0200, Francois Romieu wrote: > [...] > > > Regarding tx_dnext updates, you may add a short notice in ec_bhf_start_xmit > > > and ec_bhf_process_tx explaining that the periodic poller will somehow end > > > working with the right value, whence no (smp_)barrier at all. > > > > > Hmm, good point. I am not really sure that it is not a race. So, I've added > > memory barriers for the case when the tx ring becomes full. > > Without memory barrier, the hrtimer poller may be wrong but 1) it will > always be pessimistic and 2) it won't last. It would be sloppy though. > > Did you have some time to test the latest version ? > Yes, I have this code continuously running and it looks good. This is a regular application that I have running now, so not all interesting edge cases might have been exercised, though. -- DM -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists