[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 5 May 2014 15:40:37 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: Larry Finger <Larry.Finger@...inger.net>
Cc: Adam Lee <adam.lee@...onical.com>, linux-wireless@...r.kernel.org,
netdev@...r.kernel.org, "John W. Linville" <linville@...driver.com>
Subject: Re: [PATCH 1/3] rtlwifi: make MSI support a module parameter
On Mon, 05 May 2014 09:56:16 -0500
Larry Finger <Larry.Finger@...inger.net> wrote:
> On 05/05/2014 03:33 AM, Adam Lee wrote:
> > This makes MSI support a module parameter, for debugging and workaround
> > convenience.
> >
> > Signed-off-by: Adam Lee <adam.lee@...onical.com>
>
> Acked-by: Larry Finger <Larry.Finger@...inger.net> (for all 3 patches)
>
> I would have made the default for the MSI option to be true, but that is a
> matter of preference, and only experience would show which default leads to the
> fewer failures. On my laptop, both rtl8188ee and rtl8723be work either way. I am
> now working on a driver for the RTL8192EE that also can use MSI - that has only
> been tested with the option on.
>
> Larry
Standard practice is to assume MSI is available, and let the quirks
in the PCI subsystem reject the request to enable MSI.
Also other drivers have a 'disable_msi' module parameter why not follow
their example.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists