lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 05 May 2014 13:12:28 -0400 (EDT) From: David Miller <davem@...emloft.net> To: roopa@...ulusnetworks.com Cc: netdev@...r.kernel.org, sfeldma@...ulusnetworks.com, jiri@...nulli.us, tgraf@...g.ch, j.vosburgh@...il.com, vfalico@...il.com, andy@...yhouse.net Subject: Re: [PATCH net-next] unregister_netdevice : move RTM_DELLINK to until after ndo_uninit From: roopa@...ulusnetworks.com Date: Thu, 1 May 2014 11:40:30 -0700 > From: roopa <roopa@...ulusnetworks.com> Please fix your setup so that your real full name appears in the From: tag, not just 'roopa'. I fixed it up for you this time. > This patch fixes ordering of rtnl notifications during unregister_netdevice > by moving RTM_DELLINK notification to until after ndo_uninit. > > The problem was seen with unregistering bond netdevices. > > bond ndo_uninit callback generates a few RTM_NEWLINK notifications for > NETDEV_CHANGEADDR and NETDEV_FEAT_CHANGE. This is seen mostly when the > bond is deleted with slaves still enslaved to the bond. > > During unregister netdevice (rollback_registered_many to be specific) > bond ndo_uninit is called after RTM_DELLINK notification goes out. > This results in userspace seeing RTM_DELLINK followed by a couple of > RTM_NEWLINK's. > > In userspace problem was seen with libnl. libnl cache deletes the bond > when it sees RTM_DELLINK and re-adds the bond with the following > RTM_NEWLINK. Resulting in a stale bond entry in libnl cache when the kernel > has already deleted the bond. > > This patch has been tested for bond, bridges and vlan devices. > > Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists