netdev - Re: [PATCH net 2/2] be2net: Reset multicast promiscuous mode when its enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 05 May 2014 15:19:16 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ajit.khaparde@...lex.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net 2/2] be2net: Reset multicast promiscuous mode when
 its enabled

From: Ajit Khaparde <ajit.khaparde@...lex.com>
Date: Fri, 2 May 2014 14:43:36 -0500

> diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.c b/drivers/net/ethernet/emulex/benet/be_cmds.c
> index d1ec15a..78888ab 100644
> --- a/drivers/net/ethernet/emulex/benet/be_cmds.c
> +++ b/drivers/net/ethernet/emulex/benet/be_cmds.c
> @@ -1858,9 +1858,11 @@ int be_cmd_rx_filter(struct be_adapter *adapter, u32 flags, u32 value)
>  		/* Reset mcast promisc mode if already set by setting mask
>  		 * and not setting flags field
>  		 */
> -		req->if_flags_mask |=
> -			cpu_to_le32(BE_IF_FLAGS_MCAST_PROMISCUOUS &
> -				    be_if_cap_flags(adapter));
> +		if (adapter->flags & BE_FLAGS_MCAST_PROMISC)
> +			req->if_flags_mask |=
> +				cpu_to_le32(BE_IF_FLAGS_MCAST_PROMISCUOUS &
> +					    be_if_cap_flags(adapter));
> +

This breaks the build:

drivers/net/ethernet/emulex/benet/be_cmds.c: In function ‘be_cmd_rx_filter’:
drivers/net/ethernet/emulex/benet/be_cmds.c:1861:24: error: ‘BE_FLAGS_MCAST_PROMISC’ undeclared (first use in this function)
drivers/net/ethernet/emulex/benet/be_cmds.c:1861:24: note: each undeclared identifier is reported only once for each function it appears in