netdev - Re: [PATCH 0/8 v4] net: Checksum offload changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 05 May 2014 15:29:42 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	therbert@...gle.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 0/8 v4] net: Checksum offload changes

From: Tom Herbert <therbert@...gle.com>
Date: Fri, 2 May 2014 16:27:44 -0700 (PDT)

> I am working on overhauling RX checksum offload. Goals of this effort
> are:
> 
> - Specify what exactly it means when driver returns CHECKSUM_UNNECESSARY
> - Preserve CHECKSUM_COMPLETE through encapsulation layers
> - Don't do skb_checksum more than once per packet
> - Unify GRO and non-GRO csum verification as much as possible
> - Unify the checksum functions (checksum_init)
> - Simply code
> 
> What is in this first patch set:
> 
> - Create a common "checksum_init" function which is called from
>   TCPv{4,6} and UDPv{4,6}
> - Add some for RFC6936, UDP/IPv6 zero checksums
> - Add architecture support for csum_add and provide implementations
>   for x86_64 and Sparc 32 and 64 bit (please test the latter)
> 
> Please review carefully and test if possible, mucking with basic
> checksum functions is always a little precarious :-)

This looks really good to me, thanks for integrating all the feedback
and following up.

Series applied to net-next, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html