lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 05 May 2014 15:37:31 -0400 (EDT) From: David Miller <davem@...emloft.net> To: alchark@...il.com Cc: rl@...lgate.ch, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, fengguang.wu@...el.com Subject: Re: [PATCH] net: via-rhine: Convert #ifdef USE_MMIO to a runtime flag From: Alexey Charkov <alchark@...il.com> Date: Sat, 3 May 2014 16:40:53 +0400 > This introduces another flag in 'quirks' to replace the preprocessor > define (USE_MMIO) used to indicate whether the device needs a > separate enable routine to operate in MMIO mode. > > All of the currently known platform Rhine cores operate in MMIO > mode by default, and on PCI it is preferred over PIO for performance > reasons. However, a comment in code suggests that some (?) early > Rhine cores only work in PIO mode, so they should not be switched > to MMIO. > > Enabling MMIO on PCI is still triggered by the same Kconfig option > to avoid breaking user configs needlessly, but this can be changed > going forward towards automatic runtime detection in case a list of > PIO-only Rhine revisions can be compiled. > > This also fixes a couple of compiler warnings detected by Fengguang > Wu's test bot (!USE_MMIO case): ... > Signed-off-by: Alexey Charkov <alchark@...il.com> Applied, but in the future please make it clear what tree you are targetting by saying "[PATCH net]" or "[PATCH net-next]" in your subject line. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists