netdev - Re: [PATCH net v3] ip_tunnel: Set network header properly for IP_ECN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140505.163258.2135122265806266709.davem@davemloft.net>
Date:	Mon, 05 May 2014 16:32:58 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ycai@...gle.com
Cc:	netdev@...r.kernel.org, ncardwell@...gle.com,
	sergei.shtylyov@...entembedded.com
Subject: Re: [PATCH net v3] ip_tunnel: Set network header properly for
 IP_ECN_decapsulate()

From: Ying Cai <ycai@...gle.com>
Date: Sun,  4 May 2014 15:20:04 -0700

> In ip_tunnel_rcv(), set skb->network_header to inner IP header
> before IP_ECN_decapsulate().
> 
> Without the fix, IP_ECN_decapsulate() takes outer IP header as
> inner IP header, possibly causing error messages or packet drops.
> 
> Note that this skb_reset_network_header() call was in this spot when
> the original feature for checking consistency of ECN bits through
> tunnels was added in eccc1bb8d4b4 ("tunnel: drop packet if ECN present
> with not-ECT"). It was only removed from this spot in 3d7b46cd20e3
> ("ip_tunnel: push generic protocol handling to ip_tunnel module.").
> 
> Fixes: 3d7b46cd20e3 ("ip_tunnel: push generic protocol handling to ip_tunnel module.")
> Reported-by: Neal Cardwell <ncardwell@...gle.com>
> Signed-off-by: Ying Cai <ycai@...gle.com>
> Acked-by: Neal Cardwell <ncardwell@...gle.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html