netdev - Re: [PATCH] jme: Fix DMA unmap warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140506205046.GC2858@hmsreliant.think-freely.org>
Date:	Tue, 6 May 2014 16:50:46 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	Govindarajulu Varadarajan <_govind@....com>
Cc:	netdev@...r.kernel.org, Guo-Fu Tseng <cooldavid@...ldavid.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] jme: Fix DMA unmap warning

On Wed, May 07, 2014 at 01:55:00AM +0530, Govindarajulu Varadarajan wrote:
> 
> 
> On Mon, 5 May 2014, Neil Horman wrote:
> 
> >The jme driver forgot to check the return status from pci_map_page in its tx
> >path, causing a dma api warning on unmap.  Easy fix, just do the check and
> >augment the tx path to tell the stack that the driver is busy so we re-queue the
> >frame.
> >
> >Signed-off-by: Neil Horman <nhorman@...driver.com>
> >CC: Guo-Fu Tseng <cooldavid@...ldavid.org>
> >CC: "David S. Miller" <davem@...emloft.net>
> >---
> >drivers/net/ethernet/jme.c | 53 ++++++++++++++++++++++++++++++++++++++++------
> >1 file changed, 47 insertions(+), 6 deletions(-)
> >
> >diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c
> >index b0c6050..6e664d9 100644
> >--- a/drivers/net/ethernet/jme.c
> >+++ b/drivers/net/ethernet/jme.c
> >@@ -1988,7 +1988,7 @@ jme_alloc_txdesc(struct jme_adapter *jme,
> >	return idx;
> >}
> >
> >-static void
> >+static int
> >jme_fill_tx_map(struct pci_dev *pdev,
> >		struct txdesc *txdesc,
> >		struct jme_buffer_info *txbi,
> >@@ -2005,6 +2005,9 @@ jme_fill_tx_map(struct pci_dev *pdev,
> >				len,
> >				PCI_DMA_TODEVICE);
> >
> >+	if (unlikely(pci_dma_mapping_error(pdev, dmaaddr)))
> >+		return -EINVAL;
> >+
> >	pci_dma_sync_single_for_device(pdev,
> >				       dmaaddr,
> >				       len,
> >@@ -2021,9 +2024,30 @@ jme_fill_tx_map(struct pci_dev *pdev,
> >
> >	txbi->mapping = dmaaddr;
> >	txbi->len = len;
> >+	return 0;
> >}
> >
> >-static void
> >+static void jme_drop_tx_map(struct jme_adapter *jme, int startidx, int endidx)
> >+{
> >+	struct jme_ring *txring = &(jme->txring[0]);
> >+	struct jme_buffer_info *txbi = txring->bufinf, *ctxbi;
> >+	int mask = jme->tx_ring_mask;
> >+	int j;
> >+
> >+	for (j = startidx ; j < endidx ; ++j) {
> >+		ctxbi = txbi + ((startidx + j + 2) & (mask));
> >+		pci_unmap_page(jme->pdev,
> >+				ctxbi->mapping,
> >+				ctxbi->len,
> >+				PCI_DMA_TODEVICE);
> >+
> >+				ctxbi->mapping = 0;
> >+				ctxbi->len = 0;
> 
> Alignment, a tab from 'for'
Not sure what you mean by this, I don't see any alignment errors above, or in my
tree.  Checkpatch also claims its clean.

> >+	}
> >+
> >+}
> >+
> >+static int
> >jme_map_tx_skb(struct jme_adapter *jme, struct sk_buff *skb, int idx)
> >{
> >	struct jme_ring *txring = &(jme->txring[0]);
> >@@ -2034,25 +2058,37 @@ jme_map_tx_skb(struct jme_adapter *jme, struct sk_buff *skb, int idx)
> >	int mask = jme->tx_ring_mask;
> >	const struct skb_frag_struct *frag;
> >	u32 len;
> >+	int ret = 0;
> >
> >	for (i = 0 ; i < nr_frags ; ++i) {
> >		frag = &skb_shinfo(skb)->frags[i];
> >		ctxdesc = txdesc + ((idx + i + 2) & (mask));
> >		ctxbi = txbi + ((idx + i + 2) & (mask));
> >
> >-		jme_fill_tx_map(jme->pdev, ctxdesc, ctxbi,
> >+		ret = jme_fill_tx_map(jme->pdev, ctxdesc, ctxbi,
> >				skb_frag_page(frag),
> >				frag->page_offset, skb_frag_size(frag), hidma);
> >+		if (ret) {
> >+			jme_drop_tx_map(jme, idx, idx+i);
> >+			goto out;
> 
> Why not just return here, you are using out:, only once.
> 
Because thats in keeping with the coding style of the file, and the kernel at
large.  I could just return sure, but nominally thats only done at the head of a
function when its very clear no cleanup is needed.  This way, we keep a single
return point in the function.  Its done in several other places within this
driver already (see jme_check_link for an example)

Regards
Neil


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html